Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shorthand-values #848

Merged
merged 3 commits into from
Oct 26, 2016
Merged

Fix shorthand-values #848

merged 3 commits into from
Oct 26, 2016

Conversation

DanPurdy
Copy link
Member

For some reason the shorthand-values rule was missing the string node type and therefore any string encountered came back as null.

Fixes #847
<DCO 1.1 Signed-off-by: Dan Purdy dan@danpurdy.co.uk>

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.255% when pulling 6fff0a0 on DanPurdy:feature/fix-shorthand-values into c3a0260 on sasstools:develop.

@coveralls
Copy link

coveralls commented Aug 26, 2016 •
edited

Coverage Status

Coverage remained the same at 97.266% when pulling 0a0277a on DanPurdy:feature/fix-shorthand-values into 01eb696 on sasstools:develop.

@DanPurdy DanPurdy added this to the 1.10 milestone Sep 1, 2016
@coveralls
Copy link

coveralls commented Oct 26, 2016 •
edited

Coverage Status

Coverage remained the same at 97.529% when pulling c1aa039 on DanPurdy:feature/fix-shorthand-values into d31e7e5 on sasstools:develop.

@bgriffith bgriffith merged commit 8a3f293 into sasstools:develop Oct 26, 2016
@DanPurdy DanPurdy deleted the feature/fix-shorthand-values branch October 28, 2016 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanPurdy @coveralls @bgriffith