Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule: declarations before nesting #866

Merged
merged 5 commits into from
Oct 27, 2016
Merged

Add rule: declarations before nesting #866

merged 5 commits into from
Oct 27, 2016

Conversation

onishiweb
Copy link
Contributor

What do the changes you have made achieve?
Added new rule to lint for declarations appearing after nested rulesets

Are there any new warning messages?
Yes: "Declarations should come before nestings"

Have you written tests?
Yes

Have you included relevant documentation
Yes

Which issues does this resolve?
Closes #865

<DCO 1.1 Signed-off-by: Adam Onishi adam.onishi@ft.com>

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage increased (+0.02%) to 97.549% when pulling 9a7b528 on onishiweb:feature/declarations-before-nesting into b7bcb3a on sasstools:develop.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage increased (+0.02%) to 97.549% when pulling 9d671c4 on onishiweb:feature/declarations-before-nesting into b7bcb3a on sasstools:develop.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.549% when pulling 9d671c4 on onishiweb:feature/declarations-before-nesting into b7bcb3a on sasstools:develop.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage increased (+0.02%) to 97.549% when pulling 9d671c4 on onishiweb:feature/declarations-before-nesting into b7bcb3a on sasstools:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.549% when pulling 9d671c4 on onishiweb:feature/declarations-before-nesting into b7bcb3a on sasstools:develop.

@bgriffith
Copy link
Member

bgriffith commented Oct 26, 2016

Thanks for your PR @onishiweb - this looks great 👍 Could you update it with the latest from develop?

@coveralls
Copy link

coveralls commented Oct 27, 2016

Coverage Status

Coverage increased (+0.02%) to 97.563% when pulling 8a2168f on onishiweb:feature/declarations-before-nesting into 977f5a4 on sasstools:develop.

@DanPurdy DanPurdy merged commit 790267b into sasstools:develop Oct 27, 2016
@DanPurdy DanPurdy added this to the 1.10 milestone Oct 27, 2016
@onishiweb
Copy link
Contributor Author

Thanks @bgriffith :) Also thanks to @JakeChampion for the help with the test :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule: declarations-before-nesting
4 participants