Prevent invalid conventions border-zero #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, thanks so much for the speedy update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was highlighted in a recent comment that any convention could be supplied to the border-zero rule and no validity checking would occur leading to misleading messages such as to use the convention 'zero'.
While the docs do specify the conventions it's probably a good belts and braces measure to check ourselves and default to a good choice if it seems invalid.
This PR addresses this. An extra warning will be thrown in each file a border-zero issue occurs to inform the user of the invalid content in their config file.
<DCO 1.1 Signed-off-by: Dan Purdy dan@danpurdy.co.uk>