Add an exception for partial ident in the space-around-operator rule #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
bgriffith
force-pushed
the
feature/add-ident-exception
branch
from
1fb6ca0
to
7b42052
Compare
DanPurdy
reviewed
Nov 7, 2016
| * @returns {bool} true / false | ||
| */ | ||
| var isPartialIdent = function (operator, next, previous) { | ||
| return next.is('interpolation') && previous.is('interpolation'); |
There was a problem hiding this comment.
Are we 100% sure that next and previous will be defined, we've seen a lot of errors of the type is of undefined before.
| @@ -333,6 +333,8 @@ $qux: (2 +1) | |||
|
|
|||
| $foo: scale-color($foo, $lightness: -14%) | |||
|
|
|||
| $foobar: #{$foo}-#{$bar} | |||
There was a problem hiding this comment.
Not sure it's a working example but sassmeister parses this
$bar: 'test';
.test {
content: #{$bar}-4;
}should probably check this isn't a error either.
There was a problem hiding this comment.
Thinking about it, for a partial ident, the previous node only needs to be an interp. It doesn't matter about the next node.
There was a problem hiding this comment.
Yeah, that's what I was thinking..
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #929 which was giving a false positive when a hyphen was used in-between two interpolations. Since this hyphen
-is a partial ident, an exception has been added to the rule.<DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com>