Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4] mark "*" if there're two buses that arrives same time. #7

Merged
merged 1 commit into from
Aug 16, 2015

Conversation

pankona
Copy link
Contributor

@pankona pankona commented Aug 15, 2015

This PR is for issue #4

Updates

  • 同時刻に2台のバスが発車する場合、(2) をつけるように

Status

  • 実装
  • go test が通る

@pankona
Copy link
Contributor Author

pankona commented Aug 15, 2015

@sassy
重複した時刻に対して * をつけるようにしてみました!
試しに作ってみましたが、どうでしょうか!

@sassy
Copy link
Owner

sassy commented Aug 15, 2015

@pankona
ちょっと試してみたんですけど "*" だと、ちょっと意味がわかりづらいような気がします。
(たとえば、祝日運休とか連節バスとかいろいろ意味が取れてしまうし、拡張性もわるいので)

見てみると3台同時だけはないので、"(2)"とかの方が良いのかなと思います。

@pankona
Copy link
Contributor Author

pankona commented Aug 16, 2015

@sassy
たしかにいきなり単なる * が出ても、意味不明ですね。。
(2) にしてみます。

@pankona pankona force-pushed the 4_indicate_same_arrival branch 2 times, most recently from 96b9036 to ec01668 Compare August 16, 2015 16:44
@pankona
Copy link
Contributor Author

pankona commented Aug 16, 2015

master の変更を rebase で取り込んだうえで、*(2) に変更しました。
見た目確認してみてください!

@sassy
Copy link
Owner

sassy commented Aug 16, 2015

LGTM

sassy added a commit that referenced this pull request Aug 16, 2015
[#4] mark "*" if there're two buses that arrives same time.
@sassy sassy merged commit 4f6bcca into sassy:master Aug 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants