Scala 3 #150
Merged
Scala 3 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybasket
force-pushed
the
scala-3
branch
2 times, most recently
from
765dfdb
to
5cd2350
Compare
Split according to Scala versions (with Scala 3 being stub-only implementation for now) and minimize public API by moving everything to internal package that isn't to be used outside the library itself.
Still needs cleanup
Aka make mdoc compile again
|
@satabin I fixed the last open issues on this one, CI is fully green, so ready for a final (and thorough) review of yours. IMHO we definitely should cut another RC, the changes are big and I only found one issue (visibility of derivation helpers) through the doc compilation, so there might be more bugs appearing in actual user code. |
|
Oh, forgot one thing: The disabled Scalafmt on CI, that needs to be double-checked with the new RC4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0-RC2to buildSwitchdone in Replace contextual with literally #156, needs rebasecontextualforliterallydiffsonversion on Scala 3. PR is open: WIP: Scala 3 diffson#227bm4csv-generic