Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tag name without slug when title #179

Closed
djmtype opened this issue Dec 3, 2023 · 6 comments · Fixed by #198
Closed

Render tag name without slug when title #179

djmtype opened this issue Dec 3, 2023 · 6 comments · Fixed by #198

Comments

@djmtype
Copy link

djmtype commented Dec 3, 2023

When a tag contains more than one word it is slugified. (Yay!) However, this means the page title and meta title render with the hyphen too. (Nay!)
Maybe this is personal preference, but at least the H1 should be unslugified.

@Because789
Copy link

I'm trying to rework this part of the code at the moment anyway, but it seems that I'm not able to reproduce your issue. Could you show me an example, where this happens?

@djmtype
Copy link
Author

djmtype commented Dec 18, 2023

Again, there's nothing technically wrong, more of a question. Would the h1 and meta title be better served as capitalized, and without being hyphenated?
Screenshot 2023-12-18 at 11 11 03 AM

@Because789
Copy link

Ah, now I get it. I guess you could be right that in the end it boils down to personal taste. On the other hand, if you allow capitalized tags with spaces, why not show the original? One could argue, either allow and show them, or don't allow them.

The thing is, with how the tags pages are implemented now, I believe the change wouldn't be as trivial as one might think.

@djmtype
Copy link
Author

djmtype commented Dec 18, 2023

The thing is, with how the tags pages are implemented now, I believe the change wouldn't be as trivial as one might think.

I'm curious, what do you mean?

satnaing added a commit that referenced this issue Dec 27, 2023
Update slugified titles to be unslugified. This is for better SEO and better a11y. Url and tag elelemnts will still be slugified.

Closes: #179
@satnaing
Copy link
Owner

Hello @djmtype.
Thanks for pointing this out. I just made a PR for this and you can also check the preview URL here.

satnaing added a commit that referenced this issue Dec 28, 2023
Update slugified titles to be unslugified in the tag page. This is for better SEO and better a11y. Url and tag elelemnts will still be slugified.

Closes: #179
jeanlucaslima pushed a commit to jeanlucaslima/astro-paper that referenced this issue Dec 28, 2023
Update slugified titles to be unslugified in the tag page. This is for better SEO and better a11y. Url and tag elelemnts will still be slugified.

Closes: satnaing#179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants