Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SVG generated previews to PNG #40

Closed
SeryiBaran opened this issue Feb 24, 2023 · 1 comment · Fixed by #43 or sytjason/astro-paper#1
Closed

Convert SVG generated previews to PNG #40

SeryiBaran opened this issue Feb 24, 2023 · 1 comment · Fixed by #43 or sytjason/astro-paper#1

Comments

@SeryiBaran
Copy link

Hello!

I advise you to convert the generated previews from SVG to PNG, to bypass the OpenGraph SVG limitation.

Here is a link:
https://dev.to/anasrin/generate-image-from-html-using-satori-and-resvg-46j6

Solution to the problem Error: R] No loader is configured for ".node" files is here:
evanw/esbuild#1051 (comment)
@SeryiBaran SeryiBaran changed the title SVG previews generation to PNG Convert SVG generated previews to PNG Feb 24, 2023
satnaing added a commit that referenced this issue Mar 1, 2023
@satnaing
feat: generate og images in png format
8197877 
In production mode, generate og images from svg to png format.

fix #40
@satnaing satnaing mentioned this issue Mar 1, 2023
Merged
satnaing added a commit that referenced this issue Mar 1, 2023
@satnaing
feat: generate og images in png format (#43)
27507d1 
* feat: generate og images in png format

In production mode, generate og images from svg to png format.

fix #40

* refactor: update og image format from svg to png

Update OG image format in post detail to png. Update twitter og images to auto-generated dynamic og
images.
@satnaing
Copy link
Owner

satnaing commented Mar 1, 2023

@SeryiBaran
Thanks for opening this issue and for your suggestions.
I just merge a PR that resolves this issue. I believe it solves the SVG limitation you mentioned. Cheers! ✌🏻

@sytjason sytjason mentioned this issue Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@satnaing @SeryiBaran