Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build error astro@2.1.4 && update astro@2.1.5 #49

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

pickyzz
Copy link
Contributor

@pickyzz pickyzz commented Mar 22, 2023

Hello,

from issue #48 . I have the same issue after updating astro to 2.1.4

and I have fixed it by updating the tsconfig file

It seems like the new astro@2.1.4 was trying to call react from the wrong path.

tsconfig.json Outdated Show resolved Hide resolved
@satnaing
Copy link
Owner

Hello @pickyzz,
Thanks for your PR. I've requested one minor change and after that, I'll merge it.

@pickyzz
Copy link
Contributor Author

pickyzz commented Mar 23, 2023

Fixed. Sorry for miss checking. 😅

@satnaing
Copy link
Owner

LGTM now. Thanks!

@satnaing satnaing merged commit dd4fd98 into satnaing:main Mar 23, 2023
@satnaing satnaing mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants