Add view transitions for card on search page #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanishqmanuja Just one thing. I created Additionally, we can also put related styles back inside |
|
Sounds good to me. |
|
So, do you want to make changes on your own? Or do you want me to co-author the changes? |
|
I would be happy with both of the options. I have to do that for my fork anyways, so I will push here, if it needs any refinement you can co-author :) |
|
So far so good. I just made a small change. |
satnaing
added a commit
that referenced
this pull request
Sep 25, 2023
* feat: use predictable slug for card transition * feat: enable view transitions in search card * refactor: use Card.tsx instead of Card.astro * refactor: handle card styling in component * refactor: remove unused class name --------- Co-authored-by: Sat Naing <satnaingdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.