Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement back-to-top button in blog post page #188

Merged
merged 1 commit into from Dec 15, 2023

Conversation

satnaing
Copy link
Owner

Implement back-to-top button under tags in PostDetails page. Update html scroll-behavior to smooth.

Closes: #156

Implement back-to-top button under tags in PostDetails page. Update html scroll-behavior to smooth.

Closes: #156
Copy link

cloudflare-pages bot commented Dec 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d383464
Status: ✅  Deploy successful!
Preview URL: https://7b6edb1e.astro-paper.pages.dev
Branch Preview URL: https://feature-back-to-top-button.astro-paper.pages.dev

View logs

@Because789
Copy link

That looks great, makes much more sense like that!

While clicking around, I noticed something I haven't noticed before: In MS Edge, the title view transitions from post list to details and back are sometimes a bit wonky (it stretches over the whole box for like a ms and then snaps back). It's most visible with short titles, like the "AstroPaper 3.0" post. I thought it might have to do with the "html: smooth" change, but turns out that it was there before. It seems very situational, can't notice it in Firefox, and even in Edge it's not visible 100% of the time. One of those ugly problems, but it feels like that should be an issue of Astro itself.

@satnaing
Copy link
Owner Author

Yep.
Maybe because of view transitions api. Not sure the exact reason tho.
Hopefully will be solved eventually by upgrading Astro.

@satnaing satnaing merged commit c526157 into main Dec 15, 2023
3 checks passed
@satnaing satnaing deleted the feature/back-to-top-button branch December 15, 2023 07:51
@diomed
Copy link
Contributor

diomed commented Dec 15, 2023

very bad.

I was hoping for nice floating back to top button such as here in this example:
https://www.ub.cafe/posts/post-title-29

@Because789
Copy link

very bad.

I was hoping for nice floating back to top button such as here in this example: https://www.ub.cafe/posts/post-title-29

Dude, could you at least show some respect, when other people do work FOR FREE for you? If you don't like the implementation, make a better one for yourself. Good luck.

@diomed
Copy link
Contributor

diomed commented Dec 15, 2023

nowadays back to top buttons are more advanced, like that one in my example.

that basically isnt really a button but a link , that I could have made.

I expected a bit more complexity - like fade in/ fade out on scroll.

@Because789
Copy link

Then go and learn how to do it yourself. And if you are too lazy for that, at least learn how to ask nicely. Nobody here ows you anything, but If you show some human decency, amazing things can happen.

Anyway, you've got a lot to learn. Good luck.

Stark-X added a commit to Stark-X/my-astro-blog that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

back to top
3 participants