Abstracted generating logic behind Generator interface for easy mocking in tests
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstracted behind `Generator` interface for easy mocking in tests
satori
added a commit
that referenced
this pull request
Jan 2, 2018
Abstracted generating logic behind `Generator` interface for easy mocking in tests.
Closed
|
Merged in ceccb20 with some minor adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confines all the generation related state inside the generator object itself, allowing easy mocking in tests, w/o hijacking global crypto/rand reader
Moved all the generation related logic into
generator.go;