Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLIP-0044 - Duplicate ticker symbols #517

Closed
junderw opened this issue Jan 28, 2019 · 3 comments
Closed

SLIP-0044 - Duplicate ticker symbols #517

junderw opened this issue Jan 28, 2019 · 3 comments

Comments

@junderw
Copy link

junderw commented Jan 28, 2019

For BitcoinJS we have been converting the list into an object where the key is the ticker symbol.

Someone noticed that there are 4 pairs of duplicate tickers in the list thus far.

I have a PR that partially fixes the issue, but was wondering if you had any recommendations.

bitcoinjs/bip44-constants#30

tl;dr periodically one of the bitcoinjs team members runs node update.js > index.js and merges the new results. So console.log is output into the file and console.error does not enter the file and is shown to the terminal.

Since we put everything into an object, the coin later in the list will always overwrite the ticker with their index.

I can't think of a way to fix this besides adding _n to the ticker symbol, or manually adding the coins.

Any input would be appreciated.

BTW the current duplicates we have are:

"LBTC" is a duplicate
"DST" is a duplicate
"SAFE" is a duplicate
"BCO" is a duplicate
@junderw junderw changed the title Duplicate ticker symbols SLIP-0044 - Duplicate ticker symbols Jan 28, 2019
@junderw
Copy link
Author

junderw commented Jan 28, 2019

Actually, upon further discussion... the whole point / purpose of creating a library to dynamically input a ticker symbol and get out a BIP44 index is gone once duplicate ticker symbols exist...

If the library consumer needs to look at the symbols and run checks to make sure it's not a duplicate, then it's not a very useful library and could be just as easily done by copy pasting the needed indices into their app hard coded...

I understand Satoshi Labs has no say on which altcoins copy which ticker symbols from which altcoins, but at least maybe there can be a new rule of "no duplicate ticker symbols" and just reject PRs that break this rule.

As for the 4 sets of 2 coins duplicating each other currently... not sure what should be done there.

@mdranger
Copy link
Contributor

Enforce no duplicates would be good idea. Otherwise they should let the library consumers know the symbols can be duplicated and need to have the index or hexa in addition to the symbols.
Besides, there are some coins with no symbols, like 46, 47, 138, 191, etc.
It will be better to enforce no duplicates and no empty space for each coin.

@prusnak
Copy link
Member

prusnak commented Jan 28, 2019

There are already some duplicates and I am hesitant to force anyone to change their symbol. I agree it is a good idea to be more careful in the next PR requests.

@prusnak prusnak closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants