Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUBERIC: QuizQuestionnaire checks #23

Closed
jamcdon4 opened this issue Mar 17, 2020 · 0 comments
Closed

RUBERIC: QuizQuestionnaire checks #23

jamcdon4 opened this issue Mar 17, 2020 · 0 comments
Assignees

Comments

@jamcdon4
Copy link
Collaborator

There are three checks for whether a questionnaire is a QuizQuestionnaire. Testing the class of an object is always suspect, though in a controller, which has to control a whole hierarchy of objects, it is not necessarily wrong. However, they probably aren’t necessary.

  • One of the checks is in create_questionnaire. [method may be removed]

  • One of them deals with weights for a question, which is a kludge or hack, since managing weights should really be done in the model (superclass Questionnaire or subclass QuizQuestionnaire).

  • The third check has something to do with TreeNodes, which are Expertiza’s way of displaying objects (such as courses and assignments) that need to be shown in a hierarchy. It’s not clear what’s going on here, but I doubt that QuizQuestionnaire really has to be special.

@Sattlert2 Sattlert2 self-assigned this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants