Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ceilings for click on all images that use distributed #344

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

forana
Copy link
Contributor

@forana forana commented Apr 1, 2022

This resolves the issues we're seeing from the latest builds. This is resolved in dask/distributed#6013, so we can remove these ceilings in each image once we update to a distributed release that includes that fix.

To test locally (on images where distributed is pinned to 2021.07):

from distributed.cli import utils
utils.check_python_3()

@forana forana requested review from jsignell and bhperry April 1, 2022 14:56
Copy link
Contributor

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but the gpu images don't have ceilings on their dask versions right? So not quite sure why this is necessary for those.

@forana
Copy link
Contributor Author

forana commented Apr 1, 2022

This seems fine, but the gpu images don't have ceilings on their dask versions right? So not quite sure why this is necessary for those.

Not sure that it is, tbh, but playing it safe.

@forana forana merged commit 8e38b51 into release-2022.03.01 Apr 1, 2022
@forana forana deleted the fix/click-distributed branch April 1, 2022 16:00
hhuuggoo added a commit that referenced this pull request May 13, 2022
set ceilings for click on all images that use distributed (#344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants