rsync threadpool for batched file uploads #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhperry
force-pushed
the
bhperry/rsync-threadpooling
branch
from
e01cd21
to
04a4d4b
Compare
bhperry
changed the title
bhperry
force-pushed
the
bhperry/rsync-threadpooling
branch
from
7c52f17
to
2ca5127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using rsync, it is more likely to have many small files that need to be uploaded/downloaded. This can be quite slow with the current implementation, which is geared towards uploading large files quickly in parallel chunks.
Because SaturnFS was not written with the async implementation, fsspec's batching blocks on each file transfer until completion, so it does not actually run in batches at all. To get around this we can dispatch each file copy operation to a threadpool.