Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for [Vietnamese] #195

Closed
vuduclyunitn opened this issue Apr 13, 2020 · 5 comments
Closed

Add translation for [Vietnamese] #195

vuduclyunitn opened this issue Apr 13, 2020 · 5 comments
Assignees

Comments

@vuduclyunitn
Copy link

Expected time to finish: [4] weeks. I'll start working on it from [04/13/2020].

@vuduclyunitn vuduclyunitn changed the title Add translation for [Vietnames] Add translation for [Vietnamese] Apr 13, 2020
@satwikkansal
Copy link
Owner

Hi @vuduclyunitn

Thanks for considering this, feel free to ask any questions / doubts you face during the tranlation :)

@vuduclyunitn
Copy link
Author

Hi @satwikkansal, sorry for completing the translation late. I have completed the translation for the Vietnamese language at https://github.com/vuduclyunitn/wtfpython/blob/master/README.md. Please let me know how to proceed to integrate the translation to the main page of wtfpython. Thanks.

@satwikkansal
Copy link
Owner

Hi @vuduclyunitn

Wow, thanks, that looks neat.

I'll take care of linking your repo to the English one and adding credits :) Meanwhile, I have a couple of minor requests,

  • Could you please link to the English version in your repo (just like how the chinese version is linked at the top)
  • If it's okay, can you change the name of your fork to wtfptyhon-vi so that it's easier for others to look it up.

Finally, to add an interactive version, you can simply do this,

$ cd irrelevant
$ python notebook_generator.py

This shall output a jupyter notebook in Vietnamese if you run it in your repo. You can commit the updated notebook to your repo, create a google colab using your repo link, and then update the interactive link as well. It should look something like this.

@vuduclyunitn
Copy link
Author

Hi @satwikkansal,

Thank you for your guidance :). I have done your requests. Please let me know what I can do next.

@satwikkansal
Copy link
Owner

Thanks @vuduclyunitn

I've published your changes in the above commit. Let me know if you see any glitches.

Once again, thank you so much, I hope you enjoyed translating the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants