Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

feat: add tabBarSpacing property #1142

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

mlecoq
Copy link
Contributor

@mlecoq mlecoq commented Mar 11, 2021

Motivation

The goal is to support spacing between tabs ( see #1020 ) - It is roughly doable with some customizations (thanks to renderTabBarItem and renderIndicator methods) but it requires to modify internal methods (getTranslateX for example)

Test plan

I have added one example ( TabBarSpacingExample )

@blueberry6401
Copy link

@satya164 What do you think about this? It's very nice if we have this props.

@dparrelli
Copy link

Would definitely find this feature quite useful 👍

@hirbod
Copy link

hirbod commented Sep 1, 2021

Also add my vote on this 👍

@Kerumen
Copy link

Kerumen commented Jan 19, 2022

@mlecoq Do you have some time to rebase the PR? 🙏🏻

This way @satya164 can have a look and maybe include it in the next release!

@mlecoq
Copy link
Contributor Author

mlecoq commented Jan 19, 2022

@Kerumen I'll make it soon (tomorrow)

@github-actions
Copy link

Hey mlecoq! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@felipejh
Copy link

Would definitely find this feature quite useful +1

@okwasniewski
Copy link
Collaborator

Hey @mlecoq, thanks for your PR! Can you rebase this with the main branch? I will review this once you rebase it and test it again current pager-version.

@mlecoq
Copy link
Contributor Author

mlecoq commented Aug 31, 2022

Hey @mlecoq, thanks for your PR! Can you rebase this with the main branch? I will review this once you rebase it and test it again current pager-version.

Done !

src/TabBar.tsx Outdated Show resolved Hide resolved
example/src/AutoWidthTabBarExample.tsx Outdated Show resolved Hide resolved
src/TabView.tsx Outdated Show resolved Hide resolved
src/TabBar.tsx Outdated Show resolved Hide resolved
example/src/TabBarSpacingExample.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just for naming, please remove the tabBar prefix and change the name to gap to match the CSS property which does the same thing

src/TabView.tsx Outdated Show resolved Hide resolved
@mlecoq mlecoq force-pushed the feature/tabBarSpacing branch 7 times, most recently from 55a3131 to 88e2735 Compare September 1, 2022 07:59
@mlecoq
Copy link
Contributor Author

mlecoq commented Sep 1, 2022

Also just for naming, please remove the tabBar prefix and change the name to gap to match the CSS property which does the same thing

@okwasniewski Thanks for your feedback, I think I have taken into account all your remarks, please let me know if something is missing

@okwasniewski okwasniewski merged commit 86e66d0 into satya164:main Sep 1, 2022
@mlecoq mlecoq deleted the feature/tabBarSpacing branch September 2, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants