-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
@satya164 What do you think about this? It's very nice if we have this props. |
Would definitely find this feature quite useful 👍 |
Also add my vote on this 👍 |
@Kerumen I'll make it soon (tomorrow) |
9423de1
to
744e6a7
Compare
Hey mlecoq! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
744e6a7
to
747e905
Compare
Would definitely find this feature quite useful +1 |
Hey @mlecoq, thanks for your PR! Can you rebase this with the main branch? I will review this once you rebase it and test it again current pager-version. |
92e2ae1
to
237a1d8
Compare
Done ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just for naming, please remove the tabBar
prefix and change the name to gap
to match the CSS property which does the same thing
55a3131
to
88e2735
Compare
88e2735
to
bf467e3
Compare
@okwasniewski Thanks for your feedback, I think I have taken into account all your remarks, please let me know if something is missing |
Motivation
The goal is to support spacing between tabs ( see #1020 ) - It is roughly doable with some customizations (thanks to
renderTabBarItem
andrenderIndicator
methods) but it requires to modify internal methods (getTranslateX
for example)Test plan
I have added one example (
TabBarSpacingExample
)