Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

Scenes don't switch if swipe is released over another element #1253

Closed
1 of 5 tasks
Vannevelj opened this issue Aug 23, 2021 · 4 comments
Closed
1 of 5 tasks

Scenes don't switch if swipe is released over another element #1253

Vannevelj opened this issue Aug 23, 2021 · 4 comments

Comments

@Vannevelj
Copy link

Vannevelj commented Aug 23, 2021

Current behavior

I was on react-native-tab-view@2.15.0 and bumped the version to 3.1.1. The app allows a user to swipe between different videos which worked just fine in 2.15.0 but breaks in 3.1.1. Specifically, the gesture fails if you release the swipe over the sidebar to the right. If you lift your finger earlier on then there is no problem. Setting the tabIndex manually (i.e. via the button) works fine.

You can see in the below Detox test that swiping one way has no issue but the other way does. When I played around with it manually I noticed that halfway the sidebar seems to be the cut-off of where it would actually change the scene.

test.5.mov

Expected behavior

I expect to be able to release the swiping gesture at any point in the app and it will indeed switch scenes.

Reproduction

To come

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Environment

package version
react-native-tab-view 3.1.1
react-native-pager-view 5.4.0
react-native 0.64.2
expo -
node 14.17.5
npm or yarn yarn@1.22.11
@github-actions
Copy link

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

@github-actions
Copy link

Couldn't find version numbers for the following packages in the issue:

  • expo

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • react-native-pager-view (found: 5.1.8, latest: 5.4.0)
  • react-native (found: 0.64.2, latest: 0.65.1)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@github-actions
Copy link

Couldn't find version numbers for the following packages in the issue:

  • expo

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • react-native (found: 0.64.2, latest: 0.65.1)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@github-actions
Copy link

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant