Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

Hide invisible tabs content (by setting their height to 0) #1191

Closed
wants to merge 2 commits into from

Conversation

SiSa68
Copy link

@SiSa68 SiSa68 commented Jun 10, 2021

There is empty space on bottom of tab's scene, if other tabs height is larger than current tab

Motivation

Fix #290
In this PR I hide other tabs content (by setting their contents height to 0) to resolve this problem

Test plan

  • Add 3 tabs with different content height
  • Switch between tabs
  • Each tabs height is same as its contents height

Copy link
Owner

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it won't be smooth to change the height of content when swiping, and this may cause issues with components such as FlastList.

Please provide videos showing that it works properly in all cases.

@okwasniewski
Copy link
Collaborator

Closing this as stale

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height in different scene
3 participants