This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
Expose the style prop accepted by the Pager component #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey simonbuerger! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
okwasniewski
force-pushed
the
feature/expose-pager-style
branch
from
d968657
to
7192a2f
Compare
okwasniewski
approved these changes
Sep 8, 2022
szymonrybczak
pushed a commit
to szymonrybczak/react-native-tab-view
that referenced
this pull request
Sep 24, 2022
okwasniewski
pushed a commit
that referenced
this pull request
Sep 30, 2022
* feat: add disableChangeTabAnimation to TabView * refactor: change prop name * fix: update dependencies array * feat: add animationEnabled on web * feat: expose the style prop accepted by the Pager component (#1260) * fix: animation when swiping on web * fix: reset pendingIndexRef & remove unncecessary checks Co-authored-by: Szymon Rybczak <szymon.rybczak@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pager component already has a style prop, this just exposes it to the end user
Motivation
I have a use case where part of the custom tab bar needed to overlap part of the scene. The only way to do it would be to add a negative top margin to the Pager view, however the style prop that is exposed on the Pager view is not exposed on the TabView so currently I can't achieve this use case.