Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of the args list to String #551

Merged

Conversation

fhernandezn
Copy link
Contributor

Hi there, I was reviewing the convertArgs function and I realized that if the type of the args list is changed to String instead of Object the method can be simplified. New values can still be parsed to string since args is a class field.

Thank you for reviewing this pull request, please let me know if you have any feedback related to my pull request.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @whoshuu, @RoyMontoya and @benohalloran to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 67.488% when pulling fc285ac on frankweb:simplify-convert-args-method into a9d4b41 on satyan:master.

@sibelius sibelius merged commit 8ee7cf3 into chennaione:master Mar 28, 2016
@sibelius
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants