Add Special Regex for http_x_forwarded_for Var #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there's the possibility for the http_x_forwarded_for Nginx variable to contain a space (right after the comma separating two IP addresses), create a regex for handling this variable. Change the way the Nginx format regex is created by adding logic for including special regexes. Fixes satyrius#36 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
|
Please, add tests for your solution. And fix those which failed. |
|
Will do. |
Appears that remote_user might have spaces in it (like "mnchw monitor"). Cater for this by adding a special regex for remote_user. Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
|
Hey @jasonrogena, any update on this? |
|
Does anyone want to wrap it up? Otherwise I'm closing the PR |
|
Closing in favor of the most recent #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's the possibility for the http_x_forwarded_for Nginx
variable to contain a space (right after the comma separating two IP
addresses), create a regex for handling this variable. Change the way
the Nginx format regex is created by adding logic for including special
regexes.
Fixes #36
Signed-off-by: Jason Rogena jasonrogena@gmail.com