This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Tenacity Theme and UI/UX Changes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add custom draw tool cursor * Replace most old mouse cursors * Increase consistency with toolbar icons * Replace zoom icons in FreqWindow * Increase consistency across themes * Add custom selection adjustment cursor (The Windows ones looked like they originated from the DOS era.) ================================================================= Cherry-picked from Tenacity commit b0d9f805a657f9161cf023909c54b1b97f0732aa. Co-authored-by: Panagiotis Vasilopoulos <hello@alwayslivid.com> Signed-off-by: akleja <storspov@gmail.com> Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com> Signed-off-by: Avery King <avery98@pm.me>
|
I was stripped of time to make an actual PR merging Tenacity's themes and related changes. This is why this PR is currently a draft. Once everything is set, I will mark this as "ready to review", so we can begin the process of merging. |
* Colours applied to new elements from upstream * Light theme remake * HiContrast theme remake * Classic Theme remake * Removal of black border and shadows around tracks * Decreased contrast of bevels around TrackVRulerControls to make it fit better with the new themes. * Tweaks to track lock symbols * The unused colors have been reverted to their old colors to prevent unforeseen consequences. Cherry-picked from Tenacity commit f30d516. Changes have been made in order to let Saucedacity build, such as adjusting kVerticalPadding to 6 in order to statisfy a compile-time assertion. Signed-off-by: Avery King <avery98@pm.me> Co-authored-by: akleja <storspov@gmail.com>
Fixes a number of small coloring mistakes. Changes GraphLines color in light theme to black. Signed-off-by: akleja <storspov@gmail.com>
Makes the theme respond better to system colors Signed-off-by: akleja <storspov@gmail.com>
Adds modifier key to temporarily override sync-lock Improves the workflow when using synced tracks Changes Background of synced tracks Makes locked background tile without gaps and offsets Signed-off-by: akleja <storspov@gmail.com>
This reverts commit 956a4d6.
These changes are intended to bring the About and Splash dialogs more inline with these new themes. We no longer explicitly set any colors on any of the pages in the about dialog. We also no longer theme the Splash dialog either (although I think it can be themed, just better than how it was before). Signed-off-by: Avery King <avery98@pm.me>
Themes in Saucedacity have been reorganized quite dramatically. The following changes have been made: * Tenacity's dark theme is now the default theme. It's a pretty snazzy theme in my opinion also. * Renamed the "Default" theme to "Saucedacity". It will still be available until the end of time. * Renamed the "Classic" theme to "Audacity Classic" to show how this theme is Audacity's classic theme. Signed-off-by: Avery King <avery98@pm.me>
|
Ok. This PR is ready to be test-driven. The full list of changes follows below:
|
Added a little note about the inclusion of Tenacity code in the about dialog. Signed-off-by: Avery King <avery98@pm.me>
|
Alright. Everything is finally done now. I should be merging pretty soon! |
generic-pers0n
force-pushed
the
tenacity-themes
branch
from
755a8e2
to
bc6b90f
Compare
|
Tenacity's themes (and other changes) have been merged. Enjoy! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Partially) resolves: #43 (GitHub please don't close this issue on merge)
Merges Tenacity themes into Saucedacity along with other changes.