Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve response #26

Merged
merged 44 commits into from
Nov 9, 2020
Merged

Improve response #26

merged 44 commits into from
Nov 9, 2020

Conversation

discombobulateme
Copy link
Collaborator

One-line summary

Issues : #3 #4 #5 #6 #20 #21

Description

This PR improved output in terminal readability and creates JSON files to be used in other outputs

Need to fix

Pagination needs to be implemented, as only partial results are returning

@discombobulateme
Transform org and type values in variables
4129151
@discombobulateme
Format Date() into YY-MM-DDTHH:MM string
1532fb4
@discombobulateme
Delete func that creates file inside report dir with Date()
afbfd7b
@discombobulateme
Comment func that creates file inside report dir
9b2302a
@discombobulateme
Add func to create dir with org name and validation
7a1fcf7
@discombobulateme
Create file function
0687fa3
@discombobulateme
Add new file with date and repo name
0083539
@discombobulateme
Format json file for better readability
3f22274
@discombobulateme
Delete unecessary import
45985cf
@discombobulateme
Import utils
7d534e4
@discombobulateme
Delete unecessary template literals
c40cfa9
@discombobulateme
Delete comment
7456f1e
@discombobulateme
Use utils instead of function
4d34c33
@discombobulateme
Add validation not to create dir if already exists
9059133
@discombobulateme
Delete unecessary callback, using using promises instead
8420e81
@discombobulateme
Fix function using promises instead of Sync method
7eff40e
@discombobulateme
Delete unecessary import
0c26029
@discombobulateme
Import utils to create temporary directory
57977de
@discombobulateme
Add variables instead of fixed values
de6ed66
@discombobulateme
Format date return
c185b3d
@discombobulateme
Use utils func instead of funct in file
6f41827
@discombobulateme
Delete create file function, in use at index.js
4e4d6a3
@discombobulateme
Comment unused imports
8ef4e8d
@discombobulateme
Use function instead of const
6f340ab
@discombobulateme
Return promises to make it available when imported
1a8cadf
@discombobulateme
Change function name to be an action
dab1f9c
@discombobulateme
Delete unecessary imports
84c7ef4
@discombobulateme
Add comment about what file is about
5298b71
@discombobulateme
Add comment about what file is about
5915d15
@discombobulateme
Add side comment instead of in the upper part
22656ab
@discombobulateme discombobulateme added the enhancement New feature or request label Nov 9, 2020
@discombobulateme discombobulateme added this to the Week 45 milestone Nov 9, 2020
@discombobulateme discombobulateme added this to In progress in 3.0 enhacements via automation Nov 9, 2020
@discombobulateme discombobulateme self-assigned this Nov 9, 2020
@discombobulateme discombobulateme merged commit 12487de into main Nov 9, 2020
3.0 enhacements automation moved this from In progress to Done Nov 9, 2020
@discombobulateme discombobulateme deleted the improve-response branch November 9, 2020 12:02
This was linked to issues Nov 9, 2020
If linting passes: list passed tests #6
Closed
If linting fails: list failures #5
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol Awaiting requested review from diemol diemol is a code owner

Assignees

@discombobulateme discombobulateme

Labels
enhancement New feature or request
Projects
3.0 enhacements
Done
Milestone
Week 45
Development

Successfully merging this pull request may close these issues.

If linting passes: list passed tests If linting fails: list failures
1 participant
@discombobulateme