Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialvia: do not send default GO HTTP client User-Agent #420

Merged
merged 1 commit into from Sep 13, 2023

Conversation

Choraden
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Sep 13, 2023

PR Summary

  • Inclusion of Empty Header Field to the req Object
    The update introduces an empty 'Header' field to the 'req' object. This is earmarked for future uses and ensures additional data can be manipulated or included as necessary.

  • Addition of User-Agent Header to the req Object
    The pull request adds a 'User-Agent' to the 'req' object. This identifier will inform the server about the technology (web browser, mobile browser, applications, etc.) that initiates the request, assisting in the delivery of an optimized user experience contextually.

  • Direct Addition of Proxy-Authorization Header to the req Object
    Instead of building a new 'http.Header' object, we now directly add the 'Proxy-Authorization' header to the 'req' object. It's an efficient technique that reduces unnecessary creation of objects and optimizes resource usage.

  • Conditional Inclusion of ConnectRequestModifier to req Object
    Revised code now only adds 'ConnectRequestModifier' to the 'req' object if it's not null. This prevents unnecessary operations on an absent entity, enhancing the code's efficiency and overall performance.

@mmatczuk mmatczuk merged commit f5b3aaf into main Sep 13, 2023
3 checks passed
@mmatczuk mmatczuk deleted the hg/dialvia_user_agent branch September 13, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants