Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

martian: replace inner mutlierror with go.uber.org/multierr #422

Merged
merged 2 commits into from Sep 13, 2023

Conversation

Choraden
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Sep 13, 2023

PR Summary

  • Updated Error Handling in 'fifo_group.go' and 'fifo_group_test.go' Files
    The error handling in these files has been updated to use a more efficient error management package. By changing the type and methods used for the merr variable, and updating how multiple errors are combined, the code's performance and its readability can be improved.

  • Modified Test Cases in 'fifo_group_test.go' File
    The expected error strings in the test cases have been updated. We now use semicolons instead of new lines to separate the errors. This change increases the clarity and readability of the test results.

  • Removal of Unnecessary Files
    The files multierror.go and multierror_test.go were removed, making the overall codebase leaner. By eliminating these unused or redundant files, we are ensuring that the codebase is clean, efficient, and easier to maintain.

@mmatczuk mmatczuk merged commit 12c4cff into main Sep 13, 2023
3 checks passed
@mmatczuk mmatczuk deleted the hg/multierr branch September 13, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants