/cacert endpoint #435
Merged
/cacert endpoint #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choraden
reviewed
Sep 20, 2023
e2e/tests/flag_test.go
Outdated
| @@ -97,6 +98,24 @@ func TestFlagMITM(t *testing.T) { | |||
| ExpectHeader("test-resp-add", "test-resp-value") | |||
| } | |||
|
|
|||
| func TestFlagMITMGenCA(t *testing.T) { | |||
| r := newClient(t, proxyAPI).GET("/cacert").ExpectStatus(http.StatusOK) | |||
There was a problem hiding this comment.
It probably does not make a difference here, but the client forwards all the traffic to the proxy by default. Maybe we could add some opt direct that erases proxy function?
There was a problem hiding this comment.
ie to erase proxy function?
There was a problem hiding this comment.
yes, erase proxy function from transport.
There was a problem hiding this comment.
Done
r := newClient(t, proxyAPI, func(tr *http.Transport) {
tr.Proxy = nil
}).GET("/cacert").ExpectStatus(http.StatusOK)
Choraden
reviewed
Sep 20, 2023
e2e/forwarder/service.go
Outdated
| @@ -23,6 +23,8 @@ const ( | |||
| HttpbinServiceName = "httpbin" | |||
| ) | |||
|
|
|||
| var enabled = "true" | |||
This refactors apiEndpoint to more generic list that can be modified by different code blocks.
This tests both certificate generation and /cacert api endpoint.
mmatczuk
force-pushed
the
mmt/cacert-endpoint
branch
from
7aa04ee
to
36203af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133