Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/cobrautil: describe flags unredacted #480

Merged
merged 1 commit into from Oct 26, 2023
Merged

utils/cobrautil: describe flags unredacted #480

merged 1 commit into from Oct 26, 2023

Conversation

mmatczuk
Copy link
Contributor

We add Unredacted option to FlagsDescriber to enable getting the raw values when needed.

This is to support mmatczuk/anyflag#2

@mmatczuk
utils/cobrautil: describe flags unredacted
b03a523 
We add Unredacted option to FlagsDescriber to enable getting the raw values when needed.

This is to support mmatczuk/anyflag#2
Choraden
Choraden reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Choraden Choraden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, however I'd double check whether we need this. What is the use case of describing unredacted values? Possible security risk.

@mmatczuk
Copy link
Contributor Author

We do.

@mmatczuk mmatczuk merged commit e77d5ab into main Oct 26, 2023
4 checks passed
@mmatczuk mmatczuk deleted the mmt/describe_unredacted branch October 26, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Choraden Choraden Choraden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmatczuk @Choraden