-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add local monitoring package and a grafana dashboard #580
Conversation
Choraden
commented
Nov 30, 2023
•
edited
edited
f72655e
to
d2f28f7
Compare
Can we add max latency |
Can Go routines and threads be a diagram to see how things change over time |
Would be nice to see
|
Not exactly sure what we do now but latency should be measured for connect and upgrades separately from normal http requests. |
For things that require code changes please add separate issue for 1.2 |
d2f28f7
to
62f8918
Compare
I addressed things that did not require code change:
|
10718e3
to
5a97414
Compare
5a97414
to
5c39e5f
Compare
I chose to stay with Go Threads to indicate where the metric comes from.
I doubt if it's possible in this number form. We can always switch to standard plot, but I would stay with the one we have. I addressed all other comments. Errors diagrams will be rendered even though there is no data. Moreover, round trip errors diagram was changed to show increment instead of rate. It looks much better IMO as you can see exact number of errors that occurred instead of some random Take a look at the updated pictures or run dashboard yourself and share what you think @mmatczuk |
Nice I agree that adding increments for error codes is a good idea. Overall LGTM. |
5c39e5f
to
5f21f62
Compare
docs/content/tutorials/monitoring.md
Outdated
@@ -4,4 +4,67 @@ title: Monitoring | |||
|
|||
# Monitoring | |||
|
|||
TBD | |||
Monitoring your forward proxy is essential for ensuring its health, performance, and resource utilization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" your forward proxy "?
docs/content/tutorials/monitoring.md
Outdated
|
||
We have provided a local monitoring setup that you can use to try out the monitoring features of the Forwarder. | ||
All you need is a Docker to run Prometheus, Grafana and Forwarder. | ||
Visit [here](https://github.com/saucelabs/forwarder/blob/main/local/monitoring/README.md) for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See local/monitoring for more details.
328f8c9
to
dc51772
Compare
This is replaced by monitoring.
This makes the base url the same in both private(local) and public deployments.
dc51772
to
10ead98
Compare