dial: use OS defaults for TCP keepalive params #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatczuk
force-pushed
the
mmt/tcp_keepalive
branch
3 times, most recently
from
cfe1cbe
to
a69792a
Compare
Choraden
reviewed
Dec 15, 2023
dial_windows.go
Outdated
| d.Control = func(network, address string, c syscall.RawConn) error { | ||
| return c.Control(func(fd uintptr) { | ||
| optval := (*byte)(unsafe.Pointer(&[4]byte{1})) | ||
| if err := windows.Setsockopt(windows.Handle(fd), windows.SOL_SOCKET, windows.SO_KEEPALIVE, optval, 1); err != nil { |
There was a problem hiding this comment.
Can it be SetsockoptInt as in unix?
mmatczuk
force-pushed
the
mmt/tcp_keepalive
branch
from
a69792a
to
c2d933e
Compare
Choraden
approved these changes
Dec 18, 2023
mmatczuk
added a commit
that referenced
this pull request
Dec 19, 2023
…ers to accepted connections This is a followup to #606.
mmatczuk
added a commit
that referenced
this pull request
Dec 19, 2023
…ers to accepted connections This is a followup to #606.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605