dialvia(http): change read buffer size to hold response line #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatczuk
force-pushed
the
mmt/dialvia_read_buffer_size
branch
from
6424904
to
0328465
Compare
http.ReadResponse() calls bufio.Reader.ReadLine() to read lines. When line fits we can reuse memory and prevent additional allocation and GC. The status line should fit below 64 bytes: HTTP/1.1 (8+1 bytes) Status-Code (3+1 bytes) Reason-Phrase (<=31 bytes) CRLF (2 bytes) Total bytes: 8 + 1 + 3 + 1 + 31 = 44 With 128 bytes we can handle most header lines. As you can see we have 7% and 14% less allocs for 200 and 403 responses respectively. benchmark old ns/op new ns/op delta BenchmarkHTTPProxyDialer_DialContextR/status_200-8 29666 29483 -0.62% BenchmarkHTTPProxyDialer_DialContextR/status_403-8 83034 82855 -0.22% benchmark old allocs new allocs delta BenchmarkHTTPProxyDialer_DialContextR/status_200-8 42 39 -7.14% BenchmarkHTTPProxyDialer_DialContextR/status_403-8 62 52 -16.13% benchmark old bytes new bytes delta BenchmarkHTTPProxyDialer_DialContextR/status_200-8 3975 4023 +1.21% BenchmarkHTTPProxyDialer_DialContextR/status_403-8 5287 5079 -3.93%
mmatczuk
force-pushed
the
mmt/dialvia_read_buffer_size
branch
from
0328465
to
9369cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.ReadResponse() calls bufio.Reader.ReadLine() to read lines. When line fits we can reuse memory and prevent additional allocation and GC.
The status line should fit below 64 bytes:
HTTP/1.1 (8+1 bytes)
Status-Code (3+1 bytes)
Reason-Phrase (<=31 bytes)
CRLF (2 bytes)
Total bytes: 8 + 1 + 3 + 1 + 31 = 44
With 128 bytes we should be able to read most header lines too.