martian: improve error logging in response writing #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloseAfterReply was needed to support KGP in SauceConnect 4.9. It's not needed now.
mmatczuk
force-pushed
the
mmt/moderize_martian_v2
branch
from
6449660
to
882c011
Compare
mmatczuk
force-pushed
the
mmt/moderize_martian_v2
branch
from
882c011
to
9f13eaa
Compare
mmatczuk
changed the title
mmatczuk
force-pushed
the
mmt/moderize_martian_v2
branch
from
9f13eaa
to
4d9c84a
Compare
…n connect In 4b403a3 we added detection of client disconnects. This extends it with later added isClosedConnError() that enables it on Windows.
Choraden
reviewed
Jan 4, 2024
| req := res.Request | ||
|
|
||
| if p.WriteTimeout > 0 { | ||
| if deadlineErr := conn.SetWriteDeadline(time.Now().Add(p.WriteTimeout)); deadlineErr != nil { | ||
| log.Errorf(req.Context(), "can't set write deadline: %v", deadlineErr) | ||
| } | ||
| defer conn.SetWriteDeadline(time.Time{}) |
There was a problem hiding this comment.
We should also reset the timer while reading.
There was a problem hiding this comment.
For reading it's ok due to tricky code.
|
LGTM. It looks like the last commit's message references wrong commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extracts response writing to separate method and uses isClosedConnError() for smarter error logging like we do in case if readRequest().
CloseAfrerReply is removed for easier refactoring and later function reuse.