martian: configure proxy by exported variables only #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing it as it's not used. nosigpipe targets only darwin && go1.9, and it's for mobile i.e. running martian on iPhone. The associated issues are mostly closed, and from 2016/2017.
Proxy can be now configured using exported variables only. This is copied from http.Server, and we use initOnce pattern instead of constructor. This allows to avoid multiple overwrites of transport fields and side effects caused by invalid setter call order.
mmatczuk
force-pushed
the
mmt/martian_connect_refactoring
branch
from
0f00cd6
to
a3dc134
Compare
Avoid modifying the passed round-tripper with DialContext and ProxyURL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Proxy initialization code and remove setters.
Fixes #319