net: instrument dials #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexh-sauce
requested changes
Feb 20, 2024
command/run/run.go
Outdated
| @@ -315,6 +315,8 @@ func Command() *cobra.Command { | |||
| apiServerConfig: forwarder.DefaultHTTPServerConfig(), | |||
| logConfig: log.DefaultConfig(), | |||
| } | |||
| c.httpTransportConfig.PromRegistry = c.promReg | |||
| c.httpProxyConfig.PromNamespace = promNs | |||
There was a problem hiding this comment.
Should c.httpProxyConfig.PromNamespace = promNs be httpTransportConfig? I see c.httpProxyConfig.PromNamespace being set twice here.
Choraden
reviewed
Feb 20, 2024
Move close once feature to TrackedConn. Fix linting errors when using TrackedConn.
mmatczuk
force-pushed
the
mmt/dial_metrics_2
branch
from
ea0f07c
to
2378155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
Fixes #514
Fixes #679