Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind: change data URI scheme format in pac flag usage #744

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

Choraden
Copy link
Contributor

'<' and '>' make a mess in sc docs.

-p, --pac <path or URL> (env FORWARDER_PAC)
    Proxy Auto-Configuration file to use for upstream proxy selection. It can be a local file or a URL, you can
    also use '-' to read from stdin. The data URI scheme is supported, the format is "data:base64,encoded_data".

@Choraden
Copy link
Contributor Author

Choraden commented Mar 12, 2024

Looks like it also wasn't working in forwarder's docs, https://forwarder-proxy.io/cli/forwarder_run/#pac:
Screenshot 2024-03-12 at 20 18 50

@mmatczuk
Copy link
Contributor

So escape it.

Notice we also escape format in the first line '<path or URL>' as the first pair of backticks('`') is stripped in flag.UnquoteUsage(*flag.Flag).
@Choraden
Copy link
Contributor Author

Escaped it. Notice, we also escape format in the first line '' as the first pair of backticks('`') is stripped in flag.UnquoteUsage(*flag.Flag).

@mmatczuk mmatczuk merged commit bb4fb24 into main Mar 13, 2024
4 checks passed
@mmatczuk mmatczuk deleted the hg/escape_pac branch March 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants