Use docker or podman compose instead of docker-compose #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yaml to compose.yaml
Enable native Podman builds without fake docker binary. $ make update-devel-image STEP 1/8: FROM gcr.io/distroless/static:nonroot STEP 2/8: COPY LICENSE /licenses/ --> e745ba3153e5 STEP 3/8: COPY LICENSE.3RD_PARTY /licenses/ --> 7b82b58f2e28 STEP 4/8: COPY forwarder /usr/bin --> 5fe353e9595e STEP 5/8: ENTRYPOINT ["/usr/bin/forwarder"] --> 0d7dd897535e STEP 6/8: CMD ["run"] --> 9562b65cff9a STEP 7/8: ENV FORWARDER_API_ADDRESS="localhost:10000" --> 48741f33c951 STEP 8/8: HEALTHCHECK --interval=1s --timeout=1s --retries=10 CMD ["/usr/bin/forwarder", "ready"] COMMIT saucelabs/forwarder:devel --> 88fe020d8de3 Successfully tagged localhost/saucelabs/forwarder:devel 88fe020d8de3955e92caa82ee025a34f087ed799358330d1eedd9b11b23f62b7
Enable container health in status.
|
LGTM |
…ml to compose.yaml
time="2024-03-26T14:36:17+01:00" level=warning msg="/Users/michal/Sauce-CONNECT-5/forwarder/e2e/compose.yaml: `version` is obsolete"
Remove --remove-orphans because it's unlikely to have orphans in our usecase. Add timeout of 1s, the --force-recreate will clean stuff anyway.
This reverts commit 497e708.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman composewould preconfigure and rundocker-composeif it can find it in the path.It works out of the box and gives us the best of both worlds.
I also tried
podman-composethedocker-composealternative, but the performance is much worse and I failed to fix it in reasonable time.