fix e2e DNS issues and increase parallelism level by default #772
Conversation
Otherwise, build fails with podman in container or otherwise not configured.
e2e/run.go
Outdated
| @@ -31,7 +32,7 @@ var args = struct { | |||
| setup: flag.String("setup", "", "Only run setups matching this regexp"), | |||
| run: flag.String("run", "", "Only run tests matching this regexp"), | |||
| debug: flag.Bool("debug", false, "Enables debug logs and preserves containers after running, this will run only the first matching setup"), | |||
| parallel: flag.Int("parallel", 1, "How many setups to run in parallel"), | |||
| parallel: flag.Int("parallel", runtime.NumCPU()/2+1, "How many setups to run in parallel"), | |||
There was a problem hiding this comment.
Unfortunately, my Podman machine does not have access to all host's cpus. The parallelism becomes too high and some tests still fail.
There was a problem hiding this comment.
It's still DNS lookup error for services other than 'proxy' 🤔
There was a problem hiding this comment.
I dropped the commit. We could pass the list of services to the test program.
It happens that the services are up but the DNS name cannot be resolved yet and the test fails. This prevents that form happening and enables running with more parallelism.
If parallel=1 interrupt does not break the loop.
|
Updated DNS wait to all services. |
Other than that LGTM. |
|
I'm aware of the issues. |
Run only single test that specifies a custom network at once. This allows to have simpler tests code - portable across setups. $ make run-e2e SETUP=dns === setup flag-dns-server PASS (3.14s) === setup flag-dns-fallback PASS (10.911s) PASS
No description provided.