feat: allow tunnel timeout configuration #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhan83
previously approved these changes
Apr 2, 2024
mhan83
previously approved these changes
Apr 2, 2024
tianfeng92
reviewed
Apr 2, 2024
internal/apitest/runner.go
Outdated
| @@ -137,7 +137,14 @@ func FilterSuites(p *Project, suiteName string) error { | |||
| // RunProject runs the tests defined in apitest.Project | |||
| func (r *Runner) RunProject() (int, error) { | |||
| exitCode := 1 | |||
| if err := tunnel.ValidateTunnel(r.TunnelService, r.Project.Sauce.Tunnel.Name, r.Project.Sauce.Tunnel.Owner, tunnel.V2AlphaFilter, false); err != nil { | |||
| if err := tunnel.ValidateTunnel( | |||
There was a problem hiding this comment.
hmm... tunnel.ValidateTunnel() or tunnel.Validate()? Maybe tunnel.Validate() is better at this moment?
There was a problem hiding this comment.
Indeed, can be more concise!
tianfeng92
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the tunnel readiness timeout configurable via flags and config.
Examples: