This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fix issue #16, reverting to version before commit c217ca9 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit c217ca9 change call to IbisTableSheet to self.sheet_index(). self.sheet_index() can not be found. Reverting back to IbisTableSheet() removes the error and vdsql usable with BigQuery.
|
Hi @HerveMignot, thanks for trying to fix this. vdsql has been moved into the main visidata repo, and we'll be making any improvements over there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c217ca9 change call from
IbisTableSheet()toself.sheet_index().self.sheet_index()can not be found in the code.Reverting back to yielding
IbisTableSheet()removes the error and vdsql is then usable with BigQuery.