Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

added move left/right images #120 #125

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

StTronn
Copy link
Contributor

@StTronn StTronn commented Jan 13, 2021

Hey main changes are in generate-images.mjs added moveLeft and moveRight function. Let me know If some changes are required.

Edit:
Fixes #120
Fixes #28
Fixes #34

@netlify
Copy link

netlify bot commented Jan 13, 2021

👷 Deploy preview for text-to-handwriting processing.

🔨 Explore the source changes: 2bf2a09

🔍 Inspect the deploy logs: https://app.netlify.com/sites/text-to-handwriting/deploys/60031bda9c880f000771bc72

@StTronn
Copy link
Contributor Author

StTronn commented Jan 13, 2021

Hey, I am new to cypress so sorry for failing the test. Seems like might be an issue from ci. I have run the test locally they are passing 100%.

@saurabhdaware
Copy link
Owner

Yeah some issue with cypress

@saurabhdaware saurabhdaware self-requested a review January 16, 2021 16:24
Copy link
Owner

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks and works great!

Just mentioned some small changes. Let me know if you would like to do it :D

Thanks for the PR!

js/utils/generate-utils.mjs Outdated Show resolved Hide resolved
js/generate-images.mjs Show resolved Hide resolved
@saurabhdaware saurabhdaware self-requested a review January 17, 2021 12:51
@StTronn
Copy link
Contributor Author

StTronn commented Jan 25, 2021

Hi, Saurabh sorry I did the changes the same day but forgot to ping 😅 I have made those changes have a look and let me know of other changes :)

Copy link
Owner

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @StTronn. Thank you for contributing 🥳

@saurabhdaware saurabhdaware merged commit 6733044 into saurabhdaware:master Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants