Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case: Sorting based on job attempts #75

Closed
saurabhnanda opened this issue Jul 9, 2021 · 3 comments
Closed

Test case: Sorting based on job attempts #75

saurabhnanda opened this issue Jul 9, 2021 · 3 comments
Labels
tech-debt

Comments

@saurabhnanda
Copy link
Owner

Follow-up from #73
@saurabhnanda
Copy link
Owner Author

@jappeace just FYI if you're interested in this.

@saurabhnanda saurabhnanda changed the title Consider writing a test-case for sorting based on job attempts Test case: Sorting based on job attempts Jul 9, 2021
jappeace added a commit to SupercedeTech/odd-jobs that referenced this issue Jul 9, 2021
@jappeace
Add draft for testing the ordering of failures
4a2e629 
It doesn't work though,
Maybe I need to run another function to update
the job status? I"m not sure.

Related to saurabhnanda#75
@jappeace jappeace mentioned this issue Jul 9, 2021
Merged
@jappeace
Copy link
Collaborator

jappeace commented Jul 9, 2021

Yes, this is quite important to us, I made a draft but it's not working out like I expected. I look again at this next week.

jappeace added a commit to SupercedeTech/odd-jobs that referenced this issue Aug 4, 2021
@jappeace
Add test for testing the ordering of failures
6e9c75c 
This test will ensure that previous failed attempt get pushed to the
back of the queue.

Related to saurabhnanda#75
jappeace added a commit to SupercedeTech/odd-jobs that referenced this issue Aug 4, 2021
@jappeace
Add test for testing the ordering of failures
766c4a5 
This test will ensure that previous failed attempt get pushed to the
back of the queue.

Related to saurabhnanda#75
saurabhnanda pushed a commit that referenced this issue Aug 11, 2021
@jappeace
Add test for testing the ordering of failures (#77)
33039f3 
This test will ensure that previous failed attempt get pushed to the
back of the queue.

Related to #75
@saurabhnanda
Copy link
Owner Author

Closed by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saurabhnanda @jappeace