Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced database notification payload (Fixes saurabhnanda/odd-jobs#42) #43

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

mrputty
Copy link
Contributor

@mrputty mrputty commented Sep 18, 2020

Because PostgreSQL limits notification payloads to 8000 bytes by
default, passing the full job record in the notification artificially
limits the job payload size. By passing only required fields in the
notification, this limitation is removed.

Fixes #42

Because PostgreSQL limits notification payloads to 8000 bytes by
default, passing the full job record in the notification artificially
limits the job payload size.  By passing only required fields in the
notification, this limitation is removed.
@mrputty mrputty changed the title Reduced database notification payload (Fixes saurabhnanda/odd-jobs#42) Reduced database notification payload (Fixes #42) Sep 18, 2020
@mrputty mrputty changed the title Reduced database notification payload (Fixes #42) Reduced database notification payload (Fixes saurabhnanda/odd-jobs#42) Sep 18, 2020
@mrputty
Copy link
Contributor Author

mrputty commented Sep 18, 2020

I'm not sure why it's not, but I intended this to be linked to the related issue I opened.

@saurabhnanda
Copy link
Owner

@mrputty do you care about Hacktoberfest? I can merge this in October, or right now.

@mrputty
Copy link
Contributor Author

mrputty commented Oct 4, 2020

@mrputty do you care about Hacktoberfest? I can merge this in October, or right now.

Haha, thanks for asking. Sorry I didn't see this earlier. I don't care a bit about Hacktober, but thanks anyway.

@saurabhnanda saurabhnanda merged commit 75a0884 into saurabhnanda:master Oct 13, 2020
mrputty added a commit to mrputty/odd-jobs that referenced this pull request Oct 20, 2020
Because PostgreSQL limits notification payloads to 8000 bytes by
default, passing the full job record in the notification artificially
limits the job payload size.  By passing only required fields in the
notification, this limitation is removed.
saurabhnanda pushed a commit that referenced this pull request Nov 12, 2020
Because PostgreSQL limits notification payloads to 8000 bytes by
default, passing the full job record in the notification artificially
limits the job payload size.  By passing only required fields in the
notification, this limitation is removed.
philderbeast pushed a commit to space-vacuum/odd-jobs that referenced this pull request Apr 19, 2023
Because PostgreSQL limits notification payloads to 8000 bytes by
default, passing the full job record in the notification artificially
limits the job payload size.  By passing only required fields in the
notification, this limitation is removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL notification payload limit should not restrict job payload size
2 participants