-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache option #52
Add cache option #52
Conversation
I think using a Generic Cache adapter could suffice... Lets hear what @sausin thinks about this |
Loving it!! I think the generic adapter looks good. @wfeller Could you consider some tests for it? EDIT:- Had misread what you meant. I think memory cache support is sufficient for now. We can consider additional complexity with other drivers if times call for it |
Also just noticed, shouldn't the new dependencies be in |
No, the other dependencies are only required if the users want to use the cache features, in which case they can install them themselves (I'll add a suggest part in composer.json like Laravel does it - see https://github.com/laravel/framework/blob/1dc032a15037330c5065b84ce3937d075a673b5d/composer.json#L130). I'll update the PR to only support memory cache + tests tonight or tomorrow. |
I see, makes sense. We should reflect the same in the config documentation as well 👍 |
Looks good to me. Your thoughts @iksaku ? |
Is it useful to support multiple cache drivers like Laravel or would it be enough to simply only use the memory cache?
Solves #51