Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gender chart colors #50

Merged
merged 9 commits into from
Aug 15, 2019
Merged

Gender chart colors #50

merged 9 commits into from
Aug 15, 2019

Conversation

kimberleehowley
Copy link
Contributor

Description

I swapped out the order of the keys in our gender chart to get the right order of colors.

Checklist

  • I have performed a self-review of my own code

Copy link
Contributor

@cashcoder88 cashcoder88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, flipped the keys to resolve!

@cashcoder88
Copy link
Contributor

Turns out this is an order of operations issue. The way we import the data has to flow with the order we import the keys. Nice work Kimberlee!

@cashcoder88 cashcoder88 merged commit a6f01dd into master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants