chore: refactor record consent to take encounter id insted of patient…

… id (#339)
savannahghi · Feb 1, 2024 · 73fb3bd · 73fb3bd
1 parent 3f2b38a
commit 73fb3bd
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 30 deletions.
diff --git a/pkg/clinical/application/dto/input.go b/pkg/clinical/application/dto/input.go
@@ -132,10 +132,10 @@ type SectionInput struct {
 
 // ConsentInput models the consent input
 type ConsentInput struct {
-	Status     ConsentStatusEnum        `json:"status"`
-	Provision  ConsentProvisionTypeEnum `json:"provision,omitempty"`
-	PatientID  string                   `json:"patientID,omitempty"`
-	DenyReason string                   `json:"denyReason,omitempty"`
+	Status      ConsentStatusEnum        `json:"status"`
+	Provision   ConsentProvisionTypeEnum `json:"provision,omitempty"`
+	EncounterID string                   `json:"encounterID,omitempty"`
+	DenyReason  string                   `json:"denyReason,omitempty"`
 }
 
 // QuestionnaireResponse models input for questionnaire response resource in fhir

diff --git a/pkg/clinical/presentation/graph/generated/generated.go b/pkg/clinical/presentation/graph/generated/generated.go
diff --git a/pkg/clinical/presentation/graph/inputs.graphql b/pkg/clinical/presentation/graph/inputs.graphql
@@ -107,7 +107,7 @@ input Pagination {
 
 input ConsentInput{
   provision: ConsentProvisionTypeEnum!
-  patientID: String!
+  encounterID: String!
   denyReason: String
 }
 

diff --git a/pkg/clinical/usecases/clinical/consent.go b/pkg/clinical/usecases/clinical/consent.go
@@ -11,15 +11,20 @@ import (
 
 // RecordConsent records a user consent
 func (u *UseCasesClinicalImpl) RecordConsent(ctx context.Context, input dto.ConsentInput) (*dto.ConsentOutput, error) {
-	patient, err := u.infrastructure.FHIR.GetFHIRPatient(ctx, input.PatientID)
+	encounter, err := u.infrastructure.FHIR.GetFHIREncounter(ctx, input.EncounterID)
 	if err != nil {
 		return nil, err
 	}
 
-	patientRef := fmt.Sprintf("Patient/%s", *patient.Resource.ID)
+	if encounter.Resource.Status == domain.EncounterStatusEnumFinished {
+		return nil, fmt.Errorf("cannot create a consent in a finished encounter")
+	}
+
+	patientID := encounter.Resource.Subject.ID
+	patientReference := fmt.Sprintf("Patient/%s", *patientID)
 	subjectReference := &domain.FHIRReference{
-		ID:        patient.Resource.ID,
-		Reference: &patientRef,
+		ID:        patientID,
+		Reference: &patientReference,
 	}
 
 	scope := &domain.FHIRCodeableConcept{

diff --git a/pkg/clinical/usecases/clinical/consent_test.go b/pkg/clinical/usecases/clinical/consent_test.go
@@ -37,10 +37,10 @@ func TestUseCasesClinicalImpl_RecordConsent(t *testing.T) {
 			args: args{
 				ctx: context.Background(),
 				input: dto.ConsentInput{
-					PatientID:  ID,
-					Provision:  dto.ConsentProvisionTypeEnum(provisionType),
-					Status:     dto.ConsentStatusEnum(status),
-					DenyReason: "",
+					EncounterID: ID,
+					Provision:   dto.ConsentProvisionTypeEnum(provisionType),
+					Status:      dto.ConsentStatusEnum(status),
+					DenyReason:  "",
 				},
 			},
 			wantErr: false,
@@ -50,21 +50,21 @@ func TestUseCasesClinicalImpl_RecordConsent(t *testing.T) {
 			args: args{
 				ctx: context.Background(),
 				input: dto.ConsentInput{
-					PatientID:  ID,
-					Status:     dto.ConsentStatusEnum(status),
-					DenyReason: "",
+					EncounterID: ID,
+					Status:      dto.ConsentStatusEnum(status),
+					DenyReason:  "",
 				},
 			},
 			wantErr: true,
 		},
 		{
-			name: "Sad Case: invalid patient id",
+			name: "Sad Case: invalid encounter id",
 			args: args{
 				ctx: context.Background(),
 				input: dto.ConsentInput{
-					PatientID:  "",
-					Status:     dto.ConsentStatusEnum(status),
-					DenyReason: "",
+					EncounterID: "",
+					Status:      dto.ConsentStatusEnum(status),
+					DenyReason:  "",
 				},
 			},
 			wantErr: true,
@@ -74,9 +74,9 @@ func TestUseCasesClinicalImpl_RecordConsent(t *testing.T) {
 			args: args{
 				ctx: nil,
 				input: dto.ConsentInput{
-					PatientID:  "",
-					Status:     dto.ConsentStatusEnum(status),
-					DenyReason: "",
+					EncounterID: "",
+					Status:      dto.ConsentStatusEnum(status),
+					DenyReason:  "",
 				},
 			},
 			wantErr: true,
@@ -100,8 +100,8 @@ func TestUseCasesClinicalImpl_RecordConsent(t *testing.T) {
 				}
 
 			}
-			if tt.name == "Sad Case: invalid patient id" {
-				fakeFHIR.MockGetFHIRPatientFn = func(ctx context.Context, id string) (*domain.FHIRPatientRelayPayload, error) {
+			if tt.name == "Sad Case: invalid encounter id" {
+				fakeFHIR.MockGetFHIREncounterFn = func(ctx context.Context, id string) (*domain.FHIREncounterRelayPayload, error) {
 					return nil, fmt.Errorf("an error occurred")
 				}