Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: observation recording to update observation categories dyna… #333

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

KathurimaKimathi
Copy link
Contributor

…mically

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@KathurimaKimathi KathurimaKimathi force-pushed the update-obs-category-types-dynamically branch from 6e4007c to f9e8fc1 Compare January 30, 2024 10:37
@coveralls
Copy link

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 7710653210

  • 0 of 61 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.763%

Totals Coverage Status
Change from base Build 7708877642: 0.07%
Covered Lines: 6218
Relevant Lines: 7513

💛 - Coveralls

@KathurimaKimathi KathurimaKimathi force-pushed the update-obs-category-types-dynamically branch from f9e8fc1 to 542691e Compare January 30, 2024 11:36
…mically

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>
@KathurimaKimathi KathurimaKimathi force-pushed the update-obs-category-types-dynamically branch from 542691e to 090b434 Compare January 30, 2024 11:49
@Salaton Salaton merged commit 8677f7b into develop-v2 Jan 30, 2024
6 checks passed
@Salaton Salaton deleted the update-obs-category-types-dynamically branch January 30, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants