Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate signed url for referral reports #415

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Salaton
Copy link
Contributor

@Salaton Salaton commented Apr 5, 2024

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8567522311

Details

  • 11 of 18 (61.11%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 81.837%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/clinical/infrastructure/services/upload/upload.go 8 10 80.0%
pkg/clinical/usecases/clinical/referral_report.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/clinical/usecases/clinical/referral_report.go 1 69.31%
Totals Coverage Status
Change from base Build 8550186044: 0.04%
Covered Lines: 7322
Relevant Lines: 8947

💛 - Coveralls

@KathurimaKimathi KathurimaKimathi force-pushed the generate-signed-url branch 3 times, most recently from 2c2b370 to 0ccb32c Compare April 5, 2024 08:59
Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>
@Muchogoc Muchogoc merged commit 6793e11 into develop-v2 Apr 5, 2024
6 checks passed
@Muchogoc Muchogoc deleted the generate-signed-url branch April 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants