chore(ci): switch from flake8 to ruff #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennedykori
force-pushed
the
chore-migrate-to-ruff
branch
from
d152113
to
9838825
Compare
Switch from using [flake8](https://pypi.org/project/flake8) to [ruff](https://pypi.org/project/ruff) as the primary linter for the project. Ruff is orders of magnitude faster than alternative tools while integrating more functionality behind a single, common interface. This should help speed up linting for the project considerably and allow for much more sophisticated linting options and configurations. As a consequence of that, the following changes are included as part of this migration: - Removal of flake8 from the project’s dependencies and pre-commit hooks. - Addition of `ruff` to the project's dependencies and pre-commit hooks. - Activation of additional linting rules supported by `ruff` and the accompanying changes on the source code to conform to these rules. - Upgrading of existing dependencies. - Removal of `tox.ini`. Tox configuration is now included in the `pyproject.toml` file. All the project configuration is now housed in one file. This is in line with [PEP 621](https://peps.python.org/pep-0621) guidelines. - Minor fixes and improvements.
kennedykori
force-pushed
the
chore-migrate-to-ruff
branch
from
9838825
to
b9e4073
Compare
saladgg
approved these changes
Apr 13, 2023
|
Every config under under one file |
kennedykori
added a commit
that referenced
this pull request
Apr 13, 2023
Continue the work stated on [#67](#67) and update the static project metadata on the `pyproject.toml` file as defined on [PEP 621](https://peps.python.org/pep-0621).
saladgg
pushed a commit
that referenced
this pull request
Apr 13, 2023
Continue the work stated on [#67](#67) and update the static project metadata on the `pyproject.toml` file as defined on [PEP 621](https://peps.python.org/pep-0621).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using flake8 to ruff as the primary linter for the project. Ruff is orders of magnitude faster than alternative tools while integrating more functionality behind a single, common interface. This should help speed up linting for the project considerably and allow for much more sophisticated linting options and configurations. As a consequence of that, the following changes are included as part of this migration:
ruffto the project's dependencies and pre-commit hooks.ruffand the accompanying changes on the source code to conform to these rules.tox.ini. Tox configuration is now included in thepyproject.tomlfile. All the project configuration is now housed in one file. This is in line with PEP 621 guidelines.