feat: add site and translation to editor group perms (#251)

savannahghi · Oct 27, 2023 · f067e54 · f067e54
1 parent 38ea88e
commit f067e54
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 34 deletions.
diff --git a/mycarehub/content/signals.py b/mycarehub/content/signals.py
@@ -128,13 +128,22 @@ def create_program_content_editor_permissions(sender, instance, created, **kwarg
             )
             group.permissions.add(permission_object)
 
+        permission_object = Permission.objects.get(
+            content_type=ContentType.objects.get(
+                app_label="simple_translation", model="simpletranslation"
+            ),
+        )
+        group.permissions.add(permission_object)
+
         allowed_locale_permissions = ["add_locale", "change_locale"]
+        allowed_site_permissions = ["add_site", "change_site", "view_site"]
         allowed_workflow_permissions = ["add_workflow", "change_workflow", "delete_workflow"]
         allowed_workflowtask_permissions = ["add_task", "change_task", "delete_task"]
         for permission in (
             allowed_locale_permissions
             + allowed_workflow_permissions
             + allowed_workflowtask_permissions
+            + allowed_site_permissions
         ):
             permission_object = Permission.objects.get(
                 content_type__app_label="wagtailcore",

diff --git a/mycarehub/content/wagtail_hooks.py b/mycarehub/content/wagtail_hooks.py
@@ -2,13 +2,11 @@
 from django.urls import reverse
 from django.utils.safestring import mark_safe
 from wagtail.admin import messages
-from wagtail.admin.menu import MenuItem
 from wagtail.core import hooks
 from wagtail.documents import get_document_model
 from wagtail.images import get_image_model
 from wagtail.locales.wagtail_hooks import LocalesMenuItem
 from wagtail.models import Page
-from wagtail.permissions import site_permission_policy
 from wagtail.snippets.models import register_snippet
 
 from mycarehub.content.views.snippets import SMSContentItemTagSnippetViewSet
@@ -29,20 +27,6 @@
 )
 
 
-class WorkflowsMenuItem(MenuItem):
-    def is_shown(self, request):
-        return site_permission_policy.user_has_any_permission(
-            request.user, ["add", "change", "delete"]
-        )
-
-
-class WorkflowTasksMenuItem(MenuItem):
-    def is_shown(self, request):
-        return site_permission_policy.user_has_any_permission(
-            request.user, ["add", "change", "delete"]
-        )
-
-
 @hooks.register("insert_global_admin_js")
 def get_global_admin_js():
     return mark_safe(
@@ -172,20 +156,3 @@ def register_locales_menu_item():
     return LocalesMenuItem(
         ("Locales"), reverse("wagtaillocales:index"), icon_name="site", order=603
     )
-
-
-@hooks.register("register_admin_menu_item")
-def register_workflows_menu_item():
-    return WorkflowsMenuItem(
-        ("Workflows"), reverse("wagtailadmin_workflows:index"), icon_name="tasks", order=603
-    )
-
-
-@hooks.register("register_admin_menu_item")
-def register_workflowtask_menu_item():
-    return WorkflowTasksMenuItem(
-        ("Workflow Tasks"),
-        reverse("wagtailadmin_workflows:task_index"),
-        icon_name="thumbtack",
-        order=603,
-    )
diff --git a/mycarehub/templates/wagtailadmin/pages/listing/_list.html b/mycarehub/templates/wagtailadmin/pages/listing/_list.html
@@ -66,7 +66,12 @@
                             {% human_readable_date page.latest_revision_created_at %}
                         {% endif %}
                     </td>
-                    <td class="type" valign="top">{{ page.page_type_display_name }}</td>
+                    <td class="type" valign="top">
+                        {% if page.page_type_display_name == 'Content item' %}
+                            Rich Content
+                        {% elif page.page_type_display_name == 'Sms content item' %}
+                            SMS Content
+                        {% endif %}
                     <td class="status" valign="top">
                         {% include "wagtailadmin/shared/page_status_tag.html" with page=page %}
                     </td>